Skip to content

Basic Playwright Migration#100

Merged
digitronik merged 4 commits into
RedHatQE:feature-playwrightfrom
digitronik:playwright
Oct 15, 2025
Merged

Basic Playwright Migration#100
digitronik merged 4 commits into
RedHatQE:feature-playwrightfrom
digitronik:playwright

Conversation

@digitronik

@digitronik digitronik commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • dependencies
  • conftest plywright setup
  • chart widgets

@digitronik digitronik force-pushed the playwright branch 3 times, most recently from 09417cd to c14036c Compare October 13, 2025 16:45
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread .github/workflows/tests.yaml
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread src/widgetastic_patternfly5/charts/alerts_timeline_chart.py
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread src/widgetastic_patternfly5/charts/bullet_chart.py
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread src/widgetastic_patternfly5/charts/bullet_chart.py Outdated
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread src/widgetastic_patternfly5/charts/line_chart.py Outdated
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread testing/charts/test_bullet_chart.py
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread testing/conftest.py
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread testing/conftest.py Outdated
mshriver
mshriver reviewed Oct 15, 2025
View reviewed changes
Comment thread pyproject.toml
mshriver
mshriver requested changes Oct 15, 2025
View reviewed changes

@mshriver mshriver left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments to address and discuss, all very minor. Great work!

@digitronik digitronik requested a review from mshriver October 15, 2025 09:50
@mshriver mshriver changed the base branch from main to feature-playwright October 15, 2025 14:18
@mshriver mshriver changed the title [DO-NOT-MERGE] Playwright Migration Playwright Migration Oct 15, 2025
@mshriver mshriver marked this pull request as draft October 15, 2025 14:31
@digitronik digitronik marked this pull request as ready for review October 15, 2025 15:01
@digitronik digitronik changed the title Playwright Migration Basic Playwright Migration Oct 15, 2025
@digitronik digitronik merged commit 75d33c8 into RedHatQE:feature-playwright Oct 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshriver mshriver mshriver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@digitronik @mshriver