Migrate to functools.cached_property while preserving cached_property_with_ttl#515
Merged
Conversation
Contributor
Author
|
@ogajduse 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: ogajduse <20440883+ogajduse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Use cached_property from functools
Use cached_property from functools instead of external package
Aug 8, 2025
ogajduse
requested changes
Aug 8, 2025
Copilot
AI
changed the title
Use cached_property from functools instead of external package
Migrate to functools.cached_property while preserving cached_property_with_ttl
Aug 8, 2025
Co-authored-by: ogajduse <20440883+ogajduse@users.noreply.github.com>
014d767 to
4ea1c52
Compare
ogajduse
approved these changes
Aug 8, 2025
JacobCallahan
approved these changes
Aug 8, 2025
Gauravtalreja1
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the project from using the external
cached_propertypackage to Python's built-infunctools.cached_propertywhere possible, while preserving the library'scached_property_with_ttlimplementation for TTL functionality.Changes Made
Import Updates
from cached_property import cached_property→from functools import cached_propertyfrom cached_property import cached_property→from functools import cached_propertyfrom cached_property import threaded_cached_property→from functools import cached_propertyfrom proto.utils import cached_property→from functools import cached_propertyDependencies
cached_propertyinpyproject.tomldependencies specifically for TTL functionalityTTL Functionality Preserved
from cached_property import cached_property_with_ttlto maintain the proven library implementation for VM state caching with 1-second TTLTechnical Details
The migration strategically handles different cached property variants:
cached_property: Migrated tofunctools.cached_property(available since Python 3.8)threaded_cached_property: Replaced withfunctools.cached_property(which is already thread-safe)cached_property_with_ttl: Preserved from the library to avoid potential issues with custom TTL implementationsThis approach reduces dependency usage while maintaining the reliability of the existing TTL caching mechanism used for VM state queries.
Fixes #514.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.