Add feature flags allowing for statically linking to libclang #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building `redis-module`, on Alpine 3, a linker error occurs when trying to dynamically link libclang, a dependency of bindgen: ``` [...] Dynamic loading not supported ``` This can be worked around by statically linking to libclang. This PR allows users of this crate to enable static linking.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
Cargo.toml:150
- The default feature flag currently enables dynamic linking (bindgen-runtime), which may contradict the PR's goal of providing a static linking option on Alpine 3. Consider switching the default to 'bindgen-static' or updating the documentation to clearly explain the intended behavior.
+default = ["min-redis-compatibility-version-6-0", "bindgen-runtime"]
The default is set to runtime linking to avoid breaking existing builds. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
Cargo.toml:150
- The default feature set includes 'bindgen-runtime' (dynamic linking) even though the PR aims to allow static linking to libclang as a workaround for Alpine. Confirm if this is the intended default behavior or consider switching to 'bindgen-static' for affected platforms.
default = ["min-redis-compatibility-version-6-0", "bindgen-runtime"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building
redis-module, on Alpine 3, a linker error occurs when trying to dynamically link libclang, a dependency of bindgen:This can be worked around by statically linking to libclang. This PR allows users of this crate to enable static linking.