Skip to content

ci: Add a dry-run workflow for release PRs - #466

Open
LukeMathWalker wants to merge 1 commit into
masterfrom
dry-run
Open

ci: Add a dry-run workflow for release PRs#466
LukeMathWalker wants to merge 1 commit into
masterfrom
dry-run

Conversation

@LukeMathWalker

Copy link
Copy Markdown
Collaborator

No description provided.

@LukeMathWalker
LukeMathWalker requested a review from oshadmi May 11, 2026 06:38
# release (triggered by merging the release PR) doesn't fail mid-way.
publish-dry-run:
name: Dry-run `cargo publish` for the workspace
if: startsWith(github.head_ref, 'release-plz-')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukeMathWalker This only runs for release-plz PRs, so it catches publishability issues at release-PR time rather than when a normal PR introduces them.
If we want this as a regression check, it should probably run on all PRs to master (and also version branches in addition to master?)
Maybe add a path-filter to Cargo.toml/Cargo.lock/src changes

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but it's honestly rare to break a working publishing set-up. That's why I normally reserve this dry-run as a pre-publish sanity check.
But if you prefer we can make it part of the general CI flow.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to avoid surprises found only when we need to release/publish

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants