Skip to content

feat: changes to success criteria checks display #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DmitryAnansky
Copy link
Contributor

What/Why/How?

Add condition information to each SUCCESS_CRITERIA_CHECK display output.

Reference

Testing

Screenshots (optional)

Screenshot 2025-02-21 at 18 59 27

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 2d71496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DmitryAnansky DmitryAnansky marked this pull request as ready for review February 21, 2025 17:03
@DmitryAnansky DmitryAnansky requested a review from a team as a code owner February 21, 2025 17:03
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.17% 6916/8736
🟡 Branches 68.16% 2862/4199
🟡 Functions 74.98% 1139/1519
🟡 Lines 79.52% 6591/8288

Test suite run success

1323 tests passing in 189 suites.

Report generated by 🧪jest coverage report action from 2d71496

@DmitryAnansky DmitryAnansky merged commit e7e8c8d into feat/introduce-respect Feb 24, 2025
35 checks passed
@DmitryAnansky DmitryAnansky deleted the feat/changes-to-success-criteria-check-display branch February 24, 2025 09:25
DmitryAnansky added a commit that referenced this pull request Feb 24, 2025
* feat: add respect to cli

* chore: prettier

* chore: changes to e2e and rename to respect-core

* feat: remove respect auth

* fix: add ignored module

* chore: add files

* fix: type issue in utils

* fix: update all e2e tests

* chore: renaming

* chore: fix and simplify go-to logic

* chore: fix lint and unit tests

* chore: fix e2e for new goto

* chore: fix scripts to support respect-core

* fix parser:generate

* chore: rename ResultObject type

* chore: remove todos

* chore: sync package-lock

* chore: fix some lint errors

* chore: add secret

* chore: prettier fix

* chore: add abnf-parser to prettierignore

* chore: publish respect-core snaphot to npm

* chore: comment ignored e2e snapshot and update regexp

* fix: update cert regexp

* chore: try fixing publish and yarn smokes

* chore: try fixing publish

* chore: try fixing publish and remove smokes for node 14 and 16

* chore: fix docker smoke test

* chore: improve README and CONTRIBUTING files

* fix: cookies from workflows and step are not set to the request (#1918)

* chore: update respect command handler (#1920)

* fix: the $file decorator resolves wrong path to the file (#1921)

* chore: improve performance (#1924)

* fix: kebab case command options & mtls path & remove residensy (#1925)

* chore: cleanup resources folder (#1926)

* fix: revert dynamic imports

* chore: add dynamic import back

* chore: rename workflowId to workflowName and also targetWorkflow (#1927)

* chore: rename workflowId to workflowName and also targetWorkflow

* chore: fix tests and move outputs calc lower

* chore: run prettier

* Update packages/respect-core/src/modules/flow-runner/call-api-and-analyze-results.ts

Co-authored-by: Andrew Tatomyr <[email protected]>

---------

Co-authored-by: Andrew Tatomyr <[email protected]>

* chore: update package lock (#1929)

* feat: remove extendend option from generate-arazzo command (#1930)

* chore: fix e2e snapshots escape seq

* chore: simplify nested workflows output and flow

* chore: verbose flag was lost for nested workflows (#1934)

* chore: refactor types, descriptions and names (#1932)

* chore: improve tests (#1935)

* feat: resolve server url (#1936)

* chore: implement new json output and improve counting of steps

* chore: use json server test (#1937)

* chore: improve performance (#1941)

* feat: changes to success criteria checks display (#1943)

* feat: changes to success criteria checks display

* chore: update smoke snapshot

* chore: make check display function

* chore: update name

* chore: update smoke

* chore: update smoke again

---------

Co-authored-by: Roman Hotsiy <[email protected]>

* chore: fix default failure action

* chore: adjust license and readme

* chore: rename cli rules (#1946)

* chore: implement respect_max_steps (#1945)

* chore: implement respect_max_steps

* chore: remove recors from fake-db

* chore: fix git ignore

* chore: update e2e snapshot

* chore: fix json logs

* chore: fix types

---------

Co-authored-by: DmitryAnansky <[email protected]>

* chore: fix body always present

* chore: change max steps to 2000

* chore: rename env var

* chore: fix prettier

* chore: fix unknown step + tests

* chrore: fix json output data

---------

Co-authored-by: DmitryAnansky <[email protected]>
Co-authored-by: Roman Hotsiy <[email protected]>
Co-authored-by: Andrew Tatomyr <[email protected]>
Co-authored-by: Roman Hotsiy <[email protected]>
DmitryAnansky added a commit that referenced this pull request Feb 25, 2025
* feat: add respect to cli

* chore: prettier

* chore: changes to e2e and rename to respect-core

* feat: remove respect auth

* fix: add ignored module

* chore: add files

* fix: type issue in utils

* fix: update all e2e tests

* chore: renaming

* chore: fix and simplify go-to logic

* chore: fix lint and unit tests

* chore: fix e2e for new goto

* chore: fix scripts to support respect-core

* fix parser:generate

* chore: rename ResultObject type

* chore: remove todos

* chore: sync package-lock

* chore: fix some lint errors

* chore: add secret

* chore: prettier fix

* chore: add abnf-parser to prettierignore

* chore: publish respect-core snaphot to npm

* chore: comment ignored e2e snapshot and update regexp

* fix: update cert regexp

* chore: try fixing publish and yarn smokes

* chore: try fixing publish

* chore: try fixing publish and remove smokes for node 14 and 16

* chore: fix docker smoke test

* chore: improve README and CONTRIBUTING files

* fix: cookies from workflows and step are not set to the request (#1918)

* chore: update respect command handler (#1920)

* fix: the $file decorator resolves wrong path to the file (#1921)

* chore: improve performance (#1924)

* fix: kebab case command options & mtls path & remove residensy (#1925)

* chore: cleanup resources folder (#1926)

* fix: revert dynamic imports

* chore: add dynamic import back

* chore: rename workflowId to workflowName and also targetWorkflow (#1927)

* chore: rename workflowId to workflowName and also targetWorkflow

* chore: fix tests and move outputs calc lower

* chore: run prettier

* Update packages/respect-core/src/modules/flow-runner/call-api-and-analyze-results.ts

Co-authored-by: Andrew Tatomyr <[email protected]>

---------

Co-authored-by: Andrew Tatomyr <[email protected]>

* chore: update package lock (#1929)

* feat: remove extendend option from generate-arazzo command (#1930)

* chore: fix e2e snapshots escape seq

* chore: simplify nested workflows output and flow

* chore: verbose flag was lost for nested workflows (#1934)

* chore: refactor types, descriptions and names (#1932)

* chore: improve tests (#1935)

* feat: resolve server url (#1936)

* chore: implement new json output and improve counting of steps

* chore: use json server test (#1937)

* chore: improve performance (#1941)

* feat: changes to success criteria checks display (#1943)

* feat: changes to success criteria checks display

* chore: update smoke snapshot

* chore: make check display function

* chore: update name

* chore: update smoke

* chore: update smoke again

---------

Co-authored-by: Roman Hotsiy <[email protected]>

* chore: fix default failure action

* chore: adjust license and readme

* chore: rename cli rules (#1946)

* chore: implement respect_max_steps (#1945)

* chore: implement respect_max_steps

* chore: remove recors from fake-db

* chore: fix git ignore

* chore: update e2e snapshot

* chore: fix json logs

* chore: fix types

---------

Co-authored-by: DmitryAnansky <[email protected]>

* chore: fix body always present

* chore: change max steps to 2000

* chore: rename env var

* chore: fix prettier

* chore: fix unknown step + tests

* chrore: fix json output data

* chore: remove skipped column in workflow result table (#1948)

* fix: server selection by index (#1949)

* chore: fix json output types

* fix: replacement value evaluation (#1950)

* fix: revert warning level test

---------

Co-authored-by: DmitryAnansky <[email protected]>
Co-authored-by: Roman Hotsiy <[email protected]>
Co-authored-by: Andrew Tatomyr <[email protected]>
Co-authored-by: Roman Hotsiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants