Skip to content

fix: properly handle PR "reopen" event - #87

Merged
mark-redocly merged 2 commits into
mainfrom
fix/properly-handle-PR-reopen-event
Aug 6, 2025
Merged

fix: properly handle PR "reopen" event#87
mark-redocly merged 2 commits into
mainfrom
fix/properly-handle-PR-reopen-event

Conversation

@mark-redocly

@mark-redocly mark-redocly commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

What/Why/How?

Handling remote content on Github PR reopen event.

Reference

Closes https://github.com/Redocly/redocly/issues/12798

Testing

  1. Connect GitHub CI/CD remote as described in the here and here
  2. Open a pull request and observe the GitHub Action running.
  3. Close the pull request.
  4. Reopen the same pull request.

Expected Behavior:

A preview build should be triggered on Reunite when the pull request is reopened.

Actual Behavior:

The reunite-push-action in GitHub workflow fails with error "Invalid GitHub event data. Can not get commit sha from the event payload."

Screenshots / Video (optional)

Additional context

@mark-redocly
mark-redocly marked this pull request as ready for review August 5, 2025 17:01
@mark-redocly
mark-redocly requested review from a team and removed request for roman-sainchuk August 5, 2025 17:01
Comment thread src/helpers.ts Outdated
@mark-redocly
mark-redocly force-pushed the fix/properly-handle-PR-reopen-event branch from 19b05a5 to f7ce926 Compare August 6, 2025 11:57
@mark-redocly
mark-redocly force-pushed the fix/properly-handle-PR-reopen-event branch from f7ce926 to 7fbbbb4 Compare August 6, 2025 12:12
@mark-redocly
mark-redocly merged commit add0e20 into main Aug 6, 2025
5 checks passed
@mark-redocly
mark-redocly deleted the fix/properly-handle-PR-reopen-event branch August 6, 2025 14:12
@mark-redocly
mark-redocly restored the fix/properly-handle-PR-reopen-event branch August 6, 2025 14:12
@mark-redocly
mark-redocly deleted the fix/properly-handle-PR-reopen-event branch August 6, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants