Fix public-archive installer under the hostile C-locale environment - #34
Merged
Conversation
The operator bridge had never run end-to-end against a real published archive; the v1.4.4 install exposed two latent failures under the installer's LANG=C hardening: - release-candidate-inventory.rb rejected every filename because Ruby reports filesystem names as ASCII-8BIT under a C locale; the UTF-8 check now tests representability instead of the encoding tag. - verify-release-artifact.sh crashed with 'invalid byte sequence in US-ASCII' when regex-matching the cask (non-ASCII bytes) and Makefile under LANG=C; file reads and -ne stdin reads are now explicitly UTF-8.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while installing the published v1.4.4 archive through
scripts/install-vifty.sh --public-release-archive(the first end-to-end run of the bridge with a real published archive).release-candidate-inventory.rb: under the installer'sLANG=Chostile environment, Ruby reports filesystem names as ASCII-8BIT, so the strictencoding == UTF_8check rejected every extracted path. Now validates UTF-8 representability instead.verify-release-artifact.sh: cask regex reads (ruby -ne) crashed withinvalid byte sequence in US-ASCIIbecauseCasks/vifty.rbcontains non-ASCII bytes; Makefile file-reads were also made encoding-explicit; stdin-nereads use-E UTF-8.Verification
ReleaseCandidateInventoryTests: 41 runs, 341 assertions, 0 failures.LANG=Cagainst the v1.4.4 archive (Notarized Developer ID, Gatekeeper accepted).Non-claims