Fix no-unnecessary-key false positives on render function - #1402
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes false positives in the no-unnecessary-key rule by improving detection of render functions and correcting a critical logic bug in array method callback detection.
Changes:
- Fixed critical logic error in
isArrayMethodCallbackthat changed OR to AND operator, correcting the array method detection - Added early-exit check to skip unnecessary key validation inside render functions, preventing false positives in render prop scenarios
- Refactored
isRenderFunctionLooseto use naming-based detection (functions/props starting with "render") instead of JSX content analysis
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-key.ts | Added render function check to skip key validation and fixed logical operator bug in isArrayMethodCallback |
| packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-key.spec.ts | Removed test cases for false positives that are now fixed, added FIXME comment for remaining edge case |
| packages/core/src/component/component-render-prop.ts | Refactored isRenderFunctionLoose to accept any Node type and use naming-based detection, removed unused JSX detection imports |
| packages/core/docs/functions/isRenderFunctionLoose.md | Updated documentation to reflect new function signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rel1cx
added a commit
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information