Refactor `no-implicit-key` rule to use type checking by Rel1cx · Pull Request #1466 · Rel1cx/eslint-react

Rel1cx · 2026-02-05T12:38:39Z

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes, and the changes were approved in issue #___
No

Checklist

When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
I have added a convincing reason for adding this feature, if necessary

Other information

vercel · 2026-02-05T12:38:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
eslint-react	Ready	Preview, Comment	Feb 5, 2026 0:52am

Copilot

Pull request overview

This PR refactors the no-implicit-key rule to use TypeScript type checking instead of AST-only analysis. The rule now examines spread attributes using TypeScript's type system to detect when they implicitly pass a 'key' prop to components.

Changes:

Reimplemented the rule logic to use type checking via getConstrainedTypeAtLocation and unionConstituents
Added the rule to type-checked configurations (recommended-type-checked and strict-type-checked)
Added the rule to disable-type-checked configuration
Updated documentation across multiple files to reflect the new description and behavior
Changed test suite to use ruleTesterWithTypes instead of ruleTester

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-key.ts	Refactored rule implementation to use TypeScript type checking instead of AST analysis
packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-key.spec.ts	Updated tests to use type-checked test runner
packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-key.mdx	Updated documentation with new description and examples
packages/plugins/eslint-plugin-react-x/src/configs/recommended-type-checked.ts	Added rule to recommended-type-checked configuration
packages/plugins/eslint-plugin-react-x/src/configs/strict-type-checked.ts	Added rule to strict-type-checked configuration
packages/plugins/eslint-plugin/src/configs/recommended-type-checked.ts	Added rule to recommended-type-checked configuration
packages/plugins/eslint-plugin/src/configs/strict-type-checked.ts	Added rule to strict-type-checked configuration
packages/plugins/eslint-plugin/src/configs/disable-type-checked.ts	Added rule to disable-type-checked configuration
packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-key.mdx	Updated cross-reference description
packages/plugins/eslint-plugin-react-x/src/rules/no-missing-key.mdx	Updated cross-reference description
packages/plugins/eslint-plugin-react-x/src/rules/no-duplicate-key.mdx	Updated cross-reference description
packages/plugins/eslint-plugin-react-x/src/rules/no-array-index-key.mdx	Updated cross-reference description
packages/plugins/eslint-plugin-react-x/src/rules/jsx-key-before-spread.mdx	Updated cross-reference description
apps/website/content/docs/rules/overview.mdx	Updated rule features and presets, reformatted RSC rules table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ey.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <solarflamex@hotmail.com>

Copilot · 2026-02-05T12:43:45Z

@Rel1cx I've opened a new pull request, #1467, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-05T12:44:09Z

@Rel1cx I've opened a new pull request, #1468, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-05T12:44:20Z

@Rel1cx I've opened a new pull request, #1469, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-05T12:44:29Z

@Rel1cx I've opened a new pull request, #1470, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

#1469) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: REL1CX <solarflamex@hotmail.com>

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Rel1cx <24217275+Rel1cx@users.noreply.github.com> Co-authored-by: REL1CX <solarflamex@hotmail.com>

…#1468) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: REL1CX <solarflamex@hotmail.com>

Signed-off-by: REL1CX <solarflamex@hotmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Refactor no-implicit-key rule to use type checking

7b0c119

Rel1cx requested a review from Copilot February 5, 2026 12:38

Copilot started reviewing on behalf of Rel1cx February 5, 2026 12:39 View session

vercel Bot temporarily deployed to Preview February 5, 2026 12:40 Inactive

Remove no-implicit-key rule from all config

22bf48a

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 5, 2026

[WIP] Update no-implicit-key rule refactor based on feedback #1467

Merged

5 tasks

Update packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-k…

9f5f8c7

…ey.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <solarflamex@hotmail.com>

Copilot AI mentioned this pull request Feb 5, 2026

Fix TypeScript interface syntax in no-implicit-key rule documentation #1468

Merged

Copilot AI mentioned this pull request Feb 5, 2026

[WIP] Update to address feedback on no-implicit-key rule type checking #1469

Merged

5 tasks

Copilot AI mentioned this pull request Feb 5, 2026

[WIP] Address feedback on no-implicit-key rule refactor changes #1470

Merged

[WIP] Address feedback on no-implicit-key rule refactor changes (#1470)

92187c3

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

vercel Bot temporarily deployed to Preview February 5, 2026 12:44 Inactive

[WIP] Update to address feedback on no-implicit-key rule type checking (

6a78528

#1469) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: REL1CX <solarflamex@hotmail.com>

vercel Bot temporarily deployed to Preview February 5, 2026 12:45 Inactive

Copilot AI and others added 2 commits February 5, 2026 20:45

[WIP] Update no-implicit-key rule refactor based on feedback (#1467)

4c193d7

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Rel1cx <24217275+Rel1cx@users.noreply.github.com> Co-authored-by: REL1CX <solarflamex@hotmail.com>

Fix TypeScript interface syntax in no-implicit-key rule documentation (…

cc5e81c

…#1468) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: REL1CX <solarflamex@hotmail.com>

vercel Bot temporarily deployed to Preview February 5, 2026 12:46 Inactive

Rel1cx merged commit 423d8ee into main Feb 5, 2026
8 of 11 checks passed

Rel1cx deleted the no-implicit-key-2 branch February 5, 2026 12:46

chrisbbreuer mentioned this pull request Feb 5, 2026

chore(deps): update dependency @eslint-react/eslint-plugin to 2.10.0 stacksjs/raycast#74

Closed

ulrichstark mentioned this pull request Feb 5, 2026

@eslint-react/no-implicit-key might be overly strict for ComponentProps #1472

Closed

vladpuz mentioned this pull request Feb 6, 2026

[bug] Add no-implicit-key rule to disable-type-checked config #1477

Closed

theozhang32 mentioned this pull request Feb 9, 2026

"ts-strict-with-react" this test case reports error antfu/eslint-config#811

Open

7 tasks

Navigation Menu

Uh oh!

Refactor `no-implicit-key` rule to use type checking - #1466

Refactor `no-implicit-key` rule to use type checking#1466
Rel1cx merged 7 commits into
mainfrom
no-implicit-key-2

Rel1cx commented Feb 5, 2026

Uh oh!

vercel Bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Rel1cx commented Feb 5, 2026

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Checklist

Other information

Uh oh!

vercel Bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Feb 5, 2026 •

edited

Loading