Skip to content

ci(publish): skip scripts and remove lint step to keep publish workflow minimal - #1775

Merged
Rel1cx merged 1 commit into
mainfrom
update-publish-workflow
May 17, 2026
Merged

ci(publish): skip scripts and remove lint step to keep publish workflow minimal#1775
Rel1cx merged 1 commit into
mainfrom
update-publish-workflow

Conversation

@Rel1cx

@Rel1cx Rel1cx commented May 17, 2026

Copy link
Copy Markdown
Owner

Update "[ ]" to "[x]" to check a box

What kind of change does this PR introduce?

Check at least one. If you are introducing a new binding, you must reference an issue where this binding has been proposed, discussed and approved by the maintainers.

  • Bugfix
  • Feature
  • Perf
  • Docs
  • Test
  • Chore
  • Enhancement
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

If yes, please describe the impact and migration path for existing applications in an attached issue.

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel

vercel Bot commented May 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eslint-react Ready Ready Preview, Comment May 17, 2026 7:10am

Request Review

@Rel1cx
Rel1cx marked this pull request as ready for review May 17, 2026 07:10
@Rel1cx
Rel1cx requested a review from Copilot May 17, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the publish workflow by avoiding install-time scripts and removing the lint step before publishing packages.

Changes:

  • Adds --ignore-scripts to dependency installation.
  • Removes pnpm run lint from the publish job.
Comments suppressed due to low confidence (1)

.github/workflows/publish.yml:42

  • Removing the inline lint step means a release commit can reach pnpm publish without the repository's lint:publish/publint validation in this workflow. The separate Check workflow is not a dependency of this job, so it can fail after packages have already been published; keep at least the publish-specific lint before this step if release artifact validation is required.
      - name: Publish
        run: |
          if git log -1 --pretty=%B | grep "^release: [0-9]\+\.[0-9]\+\.[0-9]\+$";
          then
            pnpm --filter "./packages/*" --filter "./plugins/*" publish --provenance --access public

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Rel1cx
Rel1cx merged commit 1b27797 into main May 17, 2026
14 checks passed
@Rel1cx
Rel1cx deleted the update-publish-workflow branch May 17, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants