Avoid unnecessary rehash in ChunkLevelManager and TicketDistanceLevelPropagator#488
Open
InitAuther97 wants to merge 4 commits intoRelativityMC:dev/1.21.11from
Open
Avoid unnecessary rehash in ChunkLevelManager and TicketDistanceLevelPropagator#488InitAuther97 wants to merge 4 commits intoRelativityMC:dev/1.21.11from
InitAuther97 wants to merge 4 commits intoRelativityMC:dev/1.21.11from
Conversation
Contributor
|
Hello, could you provide some benchmarks and compatibility testing along with the pr? Along with hardware information and how you tested? |
Author
|
Can confirm good compatibility with VMP, Lithium and ScalableLux by running chunky and walking around in the game with no error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In ChunkLevelManager, ticket level updates are applied by removing the first entry from the update map. This introduces unnecessary shiftKey and rehash logics in our use case. We can avoid them all.