Skip to content

Preserve exclusion/include list and add Progress bar for local mod installation - #667

Merged
Sewer56 merged 16 commits into
Reloaded-Project:masterfrom
TheBestAstroNOT:preserve-exclusion-list
Nov 15, 2025
Merged

Preserve exclusion/include list and add Progress bar for local mod installation#667
Sewer56 merged 16 commits into
Reloaded-Project:masterfrom
TheBestAstroNOT:preserve-exclusion-list

Conversation

@TheBestAstroNOT

Copy link
Copy Markdown
Contributor

No description provided.

@TheBestAstroNOT TheBestAstroNOT changed the title Preserve exclusion/include list Preserve exclusion/include list and add Progress bar for local mod installation Aug 9, 2025
…Wrapper was modified

The config used to only be updated once an item was added or deleted.
@TheBestAstroNOT

TheBestAstroNOT commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

Also fixed a bug where adding $"Regex.Escape($@"{_modTuple.Config.ModId}.nuspec")}" and Regex.Escape(ModConfig.ConfigFileName) didn't save the config.

@dreamsyntax dreamsyntax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than translatable string usage

Comment thread source/Reloaded.Mod.Launcher/MainWindow.xaml.cs Outdated
Comment thread source/Reloaded.Mod.Launcher/MainWindow.xaml.cs Outdated
Comment thread source/Reloaded.Mod.Launcher/Assets/Languages/en-GB.xaml Outdated
Comment thread source/Reloaded.Mod.Launcher.Lib/Lib.cs
Makes it so they don't come back everytime you open the publish window if you remove them (though I have no idea why anyone would remove these regexes)
Comment thread source/Reloaded.Mod.Launcher/MainWindow.xaml.cs Outdated
/// <summary>
/// ViewModel for downloading an individual package.
/// </summary>
public class InstallPackageViewModel : INotifyPropertyChanged

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use autogeneration for INotifyPropertyChanged here.
It's been a while since I've worked on R2 but I believe this uses Fody.PropertyChanged.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way the rest of the project does this IIRC. Have a quick peek around.

Comment thread source/Reloaded.Mod.Loader.Update/Utilities/StringWrapper.cs Outdated
Comment thread source/Reloaded.Mod.Launcher/MainWindow.xaml.cs
Sorry for the bad commit names, it's a bit late for me rn
@Sewer56

Sewer56 commented Oct 8, 2025

Copy link
Copy Markdown
Member

I will clean this up later- god knows when, but later- still a bit of unneeded AI junk remaining.

@Sewer56

Sewer56 commented Nov 15, 2025

Copy link
Copy Markdown
Member

I resolved myself:

  • Used same INotifyPropertyChanged pattern as in rest of codebase
  • Centered InstallPackageDialog to screen so it's clear.
  • Updated IgnoreRegexes and IncludeRegexes to save only on publish or dialog close.

@Sewer56
Sewer56 merged commit 6d51c3b into Reloaded-Project:master Nov 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants