fix(auth): enforce deterministic amount precision/overflow guarantees in recovery & session flows - #1683
Merged
Merged
Conversation
…entication-and-e58dabez Update 440 files
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1642
Summary
Problem
<What was previously unguarded: e.g. no explicit scale/sign/overflow validation before
state mutation in <file/function>, allowing rounding or truncation to silently alter
stored/displayed amounts, or allowing stale/replayed auth state to reach protected paths.>
Design & Invariants
Changes
<path>:<path>:Failure Behavior & Compatibility
<error type/shape>, no state changeTest Evidence
Boundary values tested against independent oracle (
<tool/lib>):Concurrency/replay:
Commands Run
```
<formatter command + result>
<lint command + result>
<type/build command + result>
<full test suite command + result>
<security/contract/migration check command + result, if applicable>
```
Security / Correctness Note
<1 short paragraph: what this guarantees, what it does not cover, any residual
operational limitation or assumption>
Scope Confirmation