feat(auth): implement atomic rollback for sign-in, refresh, logout, a… - #1688
Merged
Baskarayelu merged 1 commit intoAug 29, 2026
Merged
Conversation
…nd recovery flows - tokens.rs: Add TokenStoreSnapshot for snapshot/restore; wrap refresh() in rollback-safe boundary so partial revocation is impossible on issuance failure. - flows.rs: refresh_session() now syncs session tokens after rotation with rollback; logout()/logout_all() use snapshot-based rollback for token revocation + session supersession. - recovery.rs: complete_recovery() snapshots both RecoveryService and TokenStore before applying side effects; rolls back all changes on issuance failure. - refreshToken.provider.ts: Reorder refresh to create-before-revoke (new token persisted first, old token revoked second); audit logging is fire-and-forget so failed writes never block auth operations. - auth.controller.ts: Replace raw Error throw in logout-all with BadRequestException for consistent HTTP semantics. - Add regression tests proving no partial state on login failure, lockout, refresh, logout, and recovery replay/cancellation. Closes Remitwise-Org#1645 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1645
…nd recovery flows
Closes #1645
🤖 Generated with Codebuff