Option to allow serializer to control filter process. For example: /api/v1/accounts?min_age=18&max_age=50#104
Open
dtee wants to merge 5 commits intoRestPack:masterfrom
Open
Option to allow serializer to control filter process. For example: /api/v1/accounts?min_age=18&max_age=50#104dtee wants to merge 5 commits intoRestPack:masterfrom
dtee wants to merge 5 commits intoRestPack:masterfrom
Conversation
/api/v1/accounts?min_age=18&max_age=50
Contributor
|
Thanks for this. Do you have other examples of how you might use this in your application? I'd like to understand the use cases before deciding on what the API should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need something that allows serializer to over ride the build in filter. This is an option I went with, something like this could also work:
@filters = filters_from_params(params, serializer)
@filters = serializer.filters_from_params(@filters, @params) if serializer.respond_to? :filters_from_params
Let know what you think of it.