Open
Conversation
benfb
added a commit
to pingboard/restpack_serializer
that referenced
this pull request
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should resolve Issue #111.
This enables Rails autoloading of the serializers as long as they are a top-level resource (not namespaced). Namespaced serializers still work, but do not get autoloaded. We think solving this problem for namespaced serializers/models will take a bigger refactor. @GavinJoyce do you have ideas on that?
There could be a performance impact from this change, since it's constantizing things rather than caching them.