This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Remove jQuery #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `camelCase` dependency to handle one of jQuery's features that we depend upon.
Add `matches` polyfill for cross-browser usage.
|
Update: The example appears to function as expected. |
ESLint has a setting for mocha, so we don't have to define the globals ourselves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found morphdom-plugins through the issue you opened on the main morphdom repo, and I'd love to use it to back the animations in
brookjs. I don't want to pull int jQuery to that project (obviously), and I saw you had a TODO to remove it, so I converted the jQuery usage to plain JS equivalents. All the tests pass. I haven't fully tested it in the browser yet, because I wanted to get this in front of you to start reviewing.I also haven't removed jQuery from the tests themselves.
I also got some odd behavior regarding the test runs. Things failed intermittently, which I chalk up to timing issues w/ the rAF calls between the tests & the lib code. Don't know what, if anything, we can do about that, but thought I'd point it out.
Let me know what you think!