feat: update Chinese language and fix translate issue #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow86
requested changes
Feb 15, 2025
Member
Flow86
left a comment
Flow86
left a comment
There was a problem hiding this comment.
there are a lot of (non translated) entries emptied. Remove those unnecessary changes please, then it looks good to me
Flow86
reviewed
Feb 15, 2025
Contributor
Author
|
@Flow86 @Flamefire Done |
Flamefire
requested changes
Feb 17, 2025
Member
Flamefire
left a comment
Flamefire
left a comment
There was a problem hiding this comment.
Just one remark. I also double-checked the handling of msgstr "":
msgfmt will remove that entry not replace it by the empty string
Hence it does indeed work in practice to leave it empty when you don't want a translation, as you intended.
However those show up as "untranslated" in most tools so putting a copy of the (untranslated) string in there shows the intention "leave this as-is" clearly to tools and translators.
Co-authored-by: Alexander Grund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.