Move Windows CI to GitHub Actions #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
fix/windows-ci
branch
13 times, most recently
from
2cd88c7 to
39650a0
Compare
The time limit of 1h is not enough to build the release version.
Flamefire
force-pushed
the
fix/windows-ci
branch
from
39650a0 to
7c757bd
Compare
`boost::filesystem::path` allows conversion from anything that is convertible to a string-ish type, like C-Strings or `std::string`. `kaguya::LuaRef` is convertible to everything (but may fail at runtime) which makes the conversion to that ambiguous. This becomes a problem for `ImageResource` which has an implicit conversion from `boost::filesystem::path` so implicitely converting `kaguya::LuaRef` to `ImageResource` will make the compiler try the conversion to `boost::filesystem::path` causing an error. Use the `get<T>` member function to avoid the atempted implicit conversion.
Flow86
reviewed
Sep 30, 2024
Flow86
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time limit of 1h is not enough to build the release version.