Fix lags in right-click scrolling for SDL2 #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
changed the title
Flow86
reviewed
Aug 24, 2025
Flow86
reviewed
Aug 25, 2025
Required e.g. for the image contro.
When warping the mouse a new event will be recorded with the SDL2 backend which might lead to handling that event multiple times. For the right-click scrolling this leads to a potential infinite loop of zero-sized movements. Fixes #1791
Remove the superflous extra method
Flamefire
force-pushed
the
warp-fix
branch
2 times, most recently
from
0bce1f5 to
136f113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid reporting duplicate mouse move events in SDL2
When warping the mouse a new event will be recorded with the SDL2
backend which might lead to handling that event multiple times.
For the right-click scrolling this leads to a potential infinite loop of
zero-sized movements.
Added an option to change the smart cursor setting in the ingame option window to test it which requires a tooltip for the checkbox due to the limited width.
Windowclass