Fix UB in test #1801
Merged
Fix UB in test #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maximum value for a random point was INT_MAX/2. We had at some point: `point + size*2` which overflows when size is in the range of INT_MAX/2. Use an upper bound of /32 for the random point values.
Flow86
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum value for a random point was INT_MAX/2. We had at some point:
point + size*2which overflows when size is in the range of INT_MAX/2. See https://github.com/Return-To-The-Roots/s25client/actions/runs/18046457107/job/51366141584?pr=1800Use an upper bound of /32 for the random point values.