Migrate amazon & debugview modules to KTS #2327
Conversation
| @@ -25,12 +25,6 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| project.afterEvaluate { | |||
| // Remove afterEvaluate | |||
| // after https://github.com/Kotlin/kotlinx-kover/issues/362 is fixed | |||
### Motivation As we've discussed, making purchases module to transitive dependency for the `ui` module. I'm going to apply for the `amazon` module as well once #2327 is merged.
|
@tonidero @JayShortway Do you have any ideas for passing the test workflow? 😄 |
…tomEntitlementComputation" flavor.
| @@ -14,6 +14,7 @@ android { | |||
| } | |||
| customEntitlementComputation { | |||
| dimension "apis" | |||
| matchingFallbacks = ["defaults"] | |||
There was a problem hiding this comment.
@skydoves This fixes it locally for me. 🤞 The way I understand the error is that :feature:amazon, :ui:revenuecatui and :ui:debugview don't declare the customEntitlementsComputation flavor, and so api-tester's customEntitlementsComputation flavor cannot find the appropriate flavor of those dependencies.
This matchingFallbacks option tells it to fall back to the defaults flavor of the dependency if it doesn't have a customEntitlementsComputation flavor. (cc @tonidero)
There was a problem hiding this comment.
Got it! Thanks so much for jumping in and fixing it directly, @JayShortway! 🙏
There was a problem hiding this comment.
Oh nice! So we do use this in these modules:
defaultConfig {
missingDimensionStrategy("apis", "defaults")
}
But seems this is not picking that up... In any case, I think this is fine 👍
There was a problem hiding this comment.
Ah right! Should "apis" be included in matchingFallbacks you think?
There was a problem hiding this comment.
Hmm well I think apis is the "dimension", vs defaults/customEntitlementComputation which are the possible values of that dimension. I think matchingFallbacks requires the value of the dimension, if I understand correctly? So I think it should be enough as it is... Might be worth confirming it would still fail API tests for the custom entitlement computation flavor though, just in case
|
Ugh, those Amazon tests are now failing with
I don't know what causes it, but I've seen it reported before: RevenueCat/purchases-kmp#271 I think it's related to the Amazon dependency and JDK version, but I don't know why it's suddenly an issue. Maybe updating the dependency from 3.0.5 to 3.0.7 helps? (Although there's nothing mentioned in the changelog.) Otherwise we can try setting |
Motivation
amazon&debugviewmodules to KTSafterEvaluatetasks. (refer to applicationVariants/libraryVariants are eagerly evaluated and result in missed test data Kotlin/kotlinx-kover#362)