-
Notifications
You must be signed in to change notification settings - Fork 75
Use fallback API hosts when receiving server down response #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9891b55
implement fallback base URL for supported endpoints
ajpallares ccdea34
Inject `fallbackBaseURLs` as a parameter to allow testing fallback ba…
ajpallares 9941512
add unit tests for fallback base URLs in `HTTPClient`'s `performReque…
ajpallares 1b98352
fix lint
ajpallares 9859294
Merge branch 'main' into fallback-api-host
ajpallares f01d12d
Always inject fallbackBaseURLs parameter in `HTTPClient`'s `performRe…
ajpallares f47b681
adapt unit tests to new parameter
ajpallares 27f131f
Merge branch 'main' into fallback-api-host
ajpallares 0373753
add unit tests for both main server and fallback server returning 500
ajpallares c1cd4b3
Merge branch 'main' into fallback-api-host
ajpallares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,7 @@ class AmazonBackendTest { | |
mockClient = mockk() | ||
mockAppConfig = mockk<AppConfig>().apply { | ||
every { baseURL } returns [email protected] | ||
every { fallbackBaseURLs } returns emptyList() | ||
} | ||
dispatcher = SyncDispatcher() | ||
backendHelper = BackendHelper(API_KEY, dispatcher, mockAppConfig, mockClient) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking to myself but should we even pass these fallback URLs for non-supported endpoints? I guess we are handling that separately though so it might be ok to do it like this so we don't forget on new endpoints, and handle in the
Endpoint
as you're doing :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had this same dilemma about this... honestly, I don't know what the best option is. That said, I wanted to avoid duplicating the logic and, most importantly, as you say, I didn't want to forget adding this on new endpoints.
My first approach was to have the
fallbackBaseURLs
parameter default toappConfig.fallbackBaseURLs
, but that led to some issues (in unit tests, IIRC).