[DO NOT MERGE]: Galaxy Store Support #2903
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Introduces the scaffolding for several classes that will be foundational to Samsung development as we move forward: - `GalaxyBillingWrapper`: implementation of `BillingAbstract`. The class currently satisfies all of the BillingAbstract's requirements, but all functions are stubbed with `TODO`s - `GalaxyPurchasingData`: will be used when processing samsung purchases - `GalaxyStoreProduct`: represents a product from the Samsung store
### Description Adds the `GALAXY` to the list of supported Store types. > Note: This PR will have one failing integration test for the Customer Center's localized strings not containing the Galaxy Store string until a backend PR has been merged.
### Description
This PR creates a new module for the Galaxy Store, and allows developers
to set up the Android SDK to use the Galaxy Store when they configure
the SDK, like so:
```kotlin
val configuration = GalaxyConfiguration.Builder(
context,
apiKey,
GalaxyBillingMode.PRODUCTION,
).build()
Purchases.configure(configuration)
```
It also:
- Introduces `GalaxyBillingMode`, an enum required when configuring the
SDK to use the Galaxy Store, which determines the environment that the
Galaxy Store processes IAPs with (prod, test, etc.).
- When a Galaxy configuration is used, `BillingFactory` will wire up a
`GalaxyBillingWrapper`
- Adds unit tests :)
…er (#2906) ### Description The Galaxy Store doesn't support fetching the current storefront/country code or showing in-app messages, so this PR: - Logs + throws an error when `GalaxyBillingWrapper.getStorefront()` is called - Adds docs explaining that the storefront functions/properties aren't supported for the Galaxy Store - Adds a comment to `GalaxyBillingWrapper` to explicitly call out that in-app messages aren't supported
Generated by 🚫 Danger |
### Description Found an error edge case where we weren't calling `finish()`. This PR updates it so that we do call finish() and future requests can execute.
Added support for Galaxy Store product changes by introducing the GalaxyReplacementMode enum and a new PurchaseParam config method .galaxyReplacementMode(). --------- Co-authored-by: Will Taylor <[email protected]> Co-authored-by: JayShortway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP for supporting the Galaxy Store.