Skip to content

Avoids consuming purchases by default #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayShortway wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoids consuming purchases by default #3003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion purchases/src/main/kotlin/com/revenuecat/purchases/PostReceiptHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ internal class PostReceiptHelper(
?.values
?.firstOrNull()
?.shouldConsume
?: true
?: false
Copy link
Contributor

@tonidero tonidero Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I think could be important... In this scenario, where it gets to this default, we shouldn't add the token to the cache of successfully posted tokens so we retry to post it on next app foreground. This way, if it was meant to be a consumable, we wouldn't have the issue of it not being able to be repurchased much longer. Wdyt?

billing.consumeAndSave(finishTransactions, purchase, shouldConsume, initiationSource)
onSuccess?.let { it(purchase, postReceiptResponse.customerInfo) }
},
Expand Down
8 changes: 4 additions & 4 deletions purchases/src/test/java/com/revenuecat/purchases/PostReceiptHelperTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,7 +1569,7 @@ class PostReceiptHelperTest {
}

@Test
fun `postTransactionAndConsumeIfNeeded tries to consume products if product data not available`() {
fun `postTransactionAndConsumeIfNeeded does not consume products if product data not available`() {
mockPostReceiptSuccess(
purchasedProductsInfo = mapOf()
)
Expand All @@ -1589,14 +1589,14 @@ class PostReceiptHelperTest {
billing.consumeAndSave(
finishTransactions = true,
purchase = mockStoreTransaction,
shouldConsume = true,
shouldConsume = false,
initiationSource = initiationSource
)
}
}

@Test
fun `postTransactionAndConsumeIfNeeded tries to consume products if product data product id does not match transactions`() {
fun `postTransactionAndConsumeIfNeeded does not consume products if product data product id does not match transactions`() {
mockPostReceiptSuccess(
purchasedProductsInfo = mapOf("other_product" to false)
)
Expand All @@ -1616,7 +1616,7 @@ class PostReceiptHelperTest {
billing.consumeAndSave(
finishTransactions = true,
purchase = mockStoreTransaction,
shouldConsume = true,
shouldConsume = false,
initiationSource = initiationSource
)
}
Expand Down