[Galaxy]: Add Samsung IAP billing permission to Galaxy manifest#3539
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
Coverage 80.11% 80.11%
=======================================
Files 371 371
Lines 15166 15166
Branches 2100 2100
=======================================
Hits 12150 12150
Misses 2166 2166
Partials 850 850 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rickvdl
approved these changes
Jun 5, 2026
rickvdl
left a comment
rickvdl
left a comment
Member
There was a problem hiding this comment.
Nice little QoL improvement 🤩
tonidero
approved these changes
Jun 5, 2026
tonidero
left a comment
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Nice! This is indeed a nice improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
com.samsung.android.iap.permission.BILLINGto the Galaxy library manifest so consuming apps inherit it automatically. The Galaxy Store looks for this permission to enable the registration of IAP items, so it's helpful for us to include this permission so that developers don't need to do this manually.This isn't a breaking change if a developer is already including this permission in their manifest. If they are, the manifest is still able to be merged without issue.
Note
Low Risk
Single manifest permission on a feature module; no runtime logic or security-sensitive code changes.
Overview
Adds the Samsung IAP billing permission (
com.samsung.android.iap.permission.BILLING) to the Galaxy libraryAndroidManifest.xmlso apps that depend on that module merge it in automatically.This avoids requiring each consuming app to declare the same permission manually for Samsung Seller Portal / billing checks.
Reviewed by Cursor Bugbot for commit 486b3dd. Bugbot is set up for automated code reviews on this repo. Configure here.