Remove Samsung IAP SDK version warning log#3546
Merged
Merged
Conversation
tonidero
approved these changes
Jun 5, 2026
tonidero
left a comment
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just a comment but nice cleanup!!
| } | ||
|
|
||
| private fun logWarningIfUnexpectedSamsungIAPVersionFound() { | ||
| val expectedSamsungIAPSDKVersion = PurchasesBuildConfig.SAMSUNG_IAP_SDK_VERSION |
Contributor
There was a problem hiding this comment.
Do we need to remove this property as well from the build.gradle?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
=======================================
Coverage 80.11% 80.11%
=======================================
Files 371 371
Lines 15166 15166
Branches 2100 2100
=======================================
Hits 12150 12150
Misses 2166 2166
Partials 850 850 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Before
purchases-androidSDK version 10.7.0, developers who wanted to use our integration with the Galaxy Store needed to obtain a copy of the Samsung IAP SDK.aarfile from the Samsung Developer Portal and manually include it in their app builds. This meant that the RevenueCat SDK could not control which version of the Samsung IAP SDK was used at runtime. To help ensure that developers used a compatible IAP SDK version, we included a warning log if the IAP SDK version provided was not expected by that version of thepurchases-androidSDK.The
purchases-androidSDK began including a copy of the Samsung IAP SDK transitively starting in version 10.7.0, as the Samsung IAP SDK started to be distributed via Maven beginning with version 6.5.2. Thus, this warning log is no longer required.Description
Removes the warning log that gets logged if the version of the Samsung IAP SDK does not match the version expected by the
purchases-androidSDK.Note
Low Risk
Logging and build-config cleanup only; no changes to purchase, restore, or billing flows.
Overview
Removes the Galaxy Store startup check that compared the Samsung IAP SDK version at runtime against a value baked into
purchases-androidand logged a warning on mismatch.That check and its supporting
BuildConfig.SAMSUNG_IAP_SDK_VERSIONfield inpurchases/build.gradle.ktsare deleted, along with related imports inGalaxyBillingWrapper. Galaxy billing initialization still sets IAP operation mode; only the obsolete version-mismatch warning path is gone now that the SDK ships Samsung IAP transitively via Maven.Reviewed by Cursor Bugbot for commit 251bf52. Bugbot is set up for automated code reviews on this repo. Configure here.