Revert inline dynamic imports for esm bundle#1631
Draft
tonidero wants to merge 3 commits into
Draft
Conversation
tonidero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We originally added a setting to inline dynamic imports since it wasn't an issue to do so and we needed it to make it work with some formats like umd used in purchases-flutter, but we want to avoid loading stripe until it's actually needed. purchases-js changes already do so, but in hybrids, this does not happen because of this setting.
For now, we're reverting this option for the esm bundle export, which is what's used by react-native-purchases, but keeping the umd export as is to avoid issues in purchases-flutter