v4: Fix main actor references in iOS 11-12 #4683
Draft
+54
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Jan 17, 2025
Comment on lines
-92
to
+93
| self.operationDispatcher.dispatchOnMainActor { | ||
| self.operationDispatcher.dispatchAsyncOnMainThread { |
There was a problem hiding this comment.
note: in this file I'm using dispatchAsyncOnMainThread and not dispatchOnMainThread. Not sure which one is best, haven't had time to dig in. But there is comment in line 307 where we're using dispatchAsyncOnMainThread saying that it must be async to prevent deadlocks, so since I didn't have time to dig in deeper I just went with that for the whole file
Comment on lines
-36
to
+40
| public typealias PurchaseCompletedBlock = @MainActor @Sendable (StoreTransaction?, | ||
| CustomerInfo?, | ||
| PublicError?, | ||
| Bool) -> Void | ||
| // todo: main actor here | ||
| public typealias PurchaseCompletedBlock = @Sendable (StoreTransaction?, | ||
| CustomerInfo?, | ||
| PublicError?, | ||
| Bool) -> Void |
There was a problem hiding this comment.
this is the most concerning one, where we are effectively doing a public-facing change. But it's one that removes restrictions, rather than adding. I expect maybe it adds some Sendable warnings?
Then again... How in the world did we add this in a minor in the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having references to
@MainActorcrashes the SDK in runtime in iOS 11 and 12 in our SDK v4 when compiling with Xcode 16 (it's not an issue in Xcode 15).We've reported this to Apple as
FB16345033.To solve this, we need to remove all references to
@MainActorfor iOS 11 and 12. Conceptually this makes sense - that should never have compiled in the first place, since iOS 11 and 12 do not support Swift Concurrency.But this is a fairly delicate open heart surgery, so we need to test it out thoroughly.