Fix/purchase-flow-need-auth-info accessibility improvements #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Tuuben! Thanks for this PR! We are changing the views quite significantly, but I'll ping you to rebase as soon as we merge so we can get some improvements out! We are going to get rid of the e-mail view (state-needs-auth-info) and have an e-mail input alongside the payment form, so this might not be needed though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Description
Hey, I was going through the codebase to familiarize myself with it and noted some accessibility stuff is missing from inputs and buttons so thought I'd commit a small fix for it. Feel free to just disregard this PR incase it's not relevant / other internal changes incoming 😊
Changes introduced
Linear ticket (if any)
Additional comments