[NOT MERGING YET] make details animation smoother #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors away the legacy <slot> API into a more V5 syntax using snippets
First pass at revamping our purchase flow. Keep in mind this PR goes against a branch `fon/new-sdk-views`. I'd love feedback on what we have until now
move to rem for spacing values for responsiveness
- Fixes alignment of button in mobile view - Renames `<Modal />` component to `<LayoutSection />` - Brings down gapXLarge of Desktop to 24px as per Iga's Request - Breaks down stories into Mobile and Desktop
Changes the checkout flow by using two new endpoints: - `/checkout/start`: Called after entering the billing email. It returns the operation ID and the required parameters to initialize the Stripe Elements components. - `/checkout/complete`: Called after submitting the payment method form. It creates the corresponding `SetupIntent` or `PayentIntent` and returns the client secret to confirm it in the SDK. - feat: Leave checkout form if a non-recoverable error occurs (e.g. product already purchased) - fix: Destroy paymentElement when unmounting the `state-needs-payment-info` - chore: Update `webbilling-demo` lock file - chore: Extract stripe-related logic into a dedicated service - chore: Improve error handling during payment info collection - fix: Set font family in Stripe Elements - chore: rename `data` field to `gateway_params` - chore: Remove unnecessary fields from `CheckoutCompleteResponse` - feat: Pick `elements_configuration` from the checkout start response - chore: Remove environment var `VITE_STORYBOOK_RESTRICTED_SECRET` - chore: Fix purchase flow stories and unit tests - feat: Replace the `PurchaseEndpoint` method with `CheckoutStartEndpoint` and `CheckoutCompleteEndpoint` - chore: Remove `svelte-stripe` dependency
Some bug bash fixes: - The arrow to "expand" should change when luminosity does - Border of email input should be 1px - Fixes how a non monthly product shows and one with trial in present offer I am waiting for design update of how to present the trial information
…er (#324) Adds support for passing an HTML Element and have the purchase flow rendered there instead of taking the whole screen
This PR: - Fixes issue when closing modal. `onDestroy` is not being called so scroll is not returned to the app - Fixes issue introduced by https://github.com/RevenueCat/purchases-js/pull/324/files#diff-890948e5715657ae559e6221fa767a9c6c771e193ddc37fc42add8c8ab491e6eL23 whereby the modal won't take the full screen when having scrolled down (since it's absolute 100%/100%). It fixes the issue by returning conditionally the previous styles, based on `isInElement`
## Motivation / Description https://www.loom.com/share/4f95a8a33d4247ec9c24325c62f7d4d1 --------- Co-authored-by: Alfonso Embid-Desmet <[email protected]>
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.