Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first implementation sent
discountCodedirectly to/checkout/startfor Stripe Billing. RevenueCat Web Billing instead represents the selected offer as a purchase option and sends that option back when checkout starts.Stripe Billing should follow the same data flow so the selected promotion code is part of the product purchase option rather than a separate checkout-start parameter.
What changed
discountCode, fetch the selected product from/productswith that code.stripe_promo;code=SUMMER20; the option keeps the product's normal price in this first implementation./checkout/startaspurchase_option_id.discount_codefield from the/checkout/startrequest and from the Stripe Checkout UI plumbing.Compatibility and rollout
discountCodecontinue using the package's selected or default purchase option without another product lookup.allow_promotion_codessetting.discountCoderemains an experimental public SDK field in this PR. Stabilizing the related discount-code APIs will be handled separately.