refactor: Add keep rules for java types#949
Merged
Merged
Conversation
ajpallares
approved these changes
Jun 10, 2026
ajpallares
left a comment
ajpallares
left a comment
Member
There was a problem hiding this comment.
Thanks!
This does mean we will need to remember to mark all java types as @keep
Is there any way we can enforce this in our PRs?
Contributor
Author
|
Added a check with a bash script in a separate PR: #953 |
tonidero
enabled auto-merge (squash)
June 11, 2026 10:41
RCGitBot
added a commit
that referenced
this pull request
Jun 18, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add presentedOfferingContext support to custom paywall impression events (#959) via Rick (@rickvdl) * feat: Add SetAppsFlyerConversionData (#956) via Toni Rico (@tonidero) ### 📦 Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.15.1 (#958) via RevenueCat Git Bot (@RCGitBot) * [Android 10.9.1](https://github.com/RevenueCat/purchases-android/releases/tag/10.9.1) * [Android 10.9.0](https://github.com/RevenueCat/purchases-android/releases/tag/10.9.0) * [iOS 5.78.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.78.0) * [iOS 5.77.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.77.0) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.15.0 (#955) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.14.1 (#954) via RevenueCat Git Bot (@RCGitBot) ### 🔄 Other Changes * chore: Add 3-day Dependabot cooldown, excluding fastlane plugin (#961) via Toni Rico (@tonidero) * Bump fastlane-plugin-revenuecat_internal from `ce6a7ef` to `70bf5c7` (#957) via dependabot[bot] (@dependabot[bot]) * ci: Enforce @keep on public Android bridge types (#953) via Toni Rico (@tonidero) * refactor: Add keep rules for java types (#949) via Toni Rico (@tonidero) * Bump fastlane from 2.236.0 to 2.236.1 (#951) via dependabot[bot] (@dependabot[bot]) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Routine release PR, but it pins newer native billing SDKs (iOS/Android via hybrid-common), which can affect purchase and attribution behavior in production builds. > > **Overview** > Automatic **9.3.0** release: bumps Unity SDK version everywhere it is reported (`.version`, `RevenueCat` / `RevenueCatUI` `package.json`, Android `PLUGIN_VERSION`, iOS `platformFlavorVersion`) and records **9.3.0** in `CHANGELOG.md`, `CHANGELOG.latest.md`, and `VERSIONS.md`. > > The release notes capture what ships with this tag: **purchases-hybrid-common 18.15.1** (iOS **5.78.0**, Android **10.9.1**), plus recently merged SDK features—**`presentedOfferingContext` on custom paywall impression events** and **`SetAppsFlyerConversionData`**—along with repo maintenance (Dependabot cooldown, Android `@Keep` / ProGuard keep rules, fastlane bumps). No additional runtime code changes appear in this diff beyond the version strings. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 234e38b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're working to narrow down our consumer rules in RevenueCat/purchases-android#3557. However, this makes it not find our code anymore in Unity when minifying since nothing is directly referencing the Java types from Unity. This adds some Keep annotations that from my tests avoid the issue. This does mean we will need to remember to mark all java types as
@Keepbut it was easier than trying to add proguard rules to be used by our customers when importing our plugins.Note this won't do anything until the purchases-android changes actually get merged