Stop species dropdown entries from colouring the selection radio buttons#6344
Stop species dropdown entries from colouring the selection radio buttons#6344LMartin188 wants to merge 3 commits intoRevolutionary-Games:masterfrom
Conversation
Removed the Popup.SetItemIconModulate(index, item.Color); line from checkable items
Fixes the unintentional colouring of the selection button while keeping the species colour sphere intact.
|
Thank you for contributing to Thrive. Before your contribution can be accepted, you need to sign our CLA. Once your contribution has been accepted you can ask to be included in the credits (https://wiki.revolutionarygamesstudio.com/wiki/Team_Members) and you can apply to join the team and use this work as a sample: https://revolutionarygamesstudio.com/application/ |
| Popup.AddIconCheckItem(tintedIcon, item.Text, id); | ||
| var index = Popup.GetItemIndex(id); | ||
| Popup.SetItemIconMaxWidth(index, iconMaxWidth); | ||
| Popup.SetItemIconModulate(index, item.Color); |
There was a problem hiding this comment.
Upon reading that this SetItemIconModulate is from Godot, I think this might actually be an engine bug that should be reported that Godot 4 now applies icon modulation to the radiobutton as well rather than the icon only.
|
This PR has been inactive for a while and as such is being marked If this is still being worked on / will probably resume work at |
|
The lead programmer for Thrive is currently on vacation until 2026-01-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged. |
4 participants
closes #6307