Skip to content

Chemosynthesis buff#6597

Open
domin2ktr wants to merge 2 commits intoRevolutionary-Games:masterfrom
domin2ktr:Chemosynthesis-buff
Open

Chemosynthesis buff#6597
domin2ktr wants to merge 2 commits intoRevolutionary-Games:masterfrom
domin2ktr:Chemosynthesis-buff

Conversation

@domin2ktr
Copy link
Contributor

@domin2ktr domin2ktr commented Dec 21, 2025

Brief Description of What This PR Does

This PR increases the efficiency of chemosynthesis severalfold.

Why?

The fact is that chemosynthesis is terribly inefficient; it's barely enough for large prokaryotes to survive. And chemosynthetic eukaryotes starve even standing in a cloud of hydrogen sulfide.

In real life, chemosynthesis is efficient enough to fuel even some macroscopic organisms.

Furthermore, it requires organelles to convert glucose into ATP, which requires more organelles and, consequently, osmoregulation.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

@revolutionary-bot
Copy link

The lead programmer for Thrive is currently on vacation until 2026-01-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed.

PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged.

@Accidental-Explorer
Copy link
Contributor

Accidental-Explorer commented Dec 22, 2025

Haven't had a chance to test yet, but:

I see you made prokaryotic chemosynthesis twice as efficient, but eukaryotic chemosynthesis almost 4 times more efficient. Is that much of a difference really necessary?

(I do see that pre-this PR, the eukaryotic version is less efficient, so the current state in master is definitely also not good)

@hhyyrylainen hhyyrylainen changed the title Chemosynthesys buff Chemosynthesis buff Jan 7, 2026
Copy link
Contributor

@Accidental-Explorer Accidental-Explorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this balance already feels overall better for larger species.

At first I thought the increased efficiency for the chemoplast was a bit too much, but it's actually pretty consistent with the other eukaryote organelles. I actually think it could be tuned up a bit more. (And the CO2 input updated to match the glucose output).

I would do:

    "Inputs": {
      "hydrogensulfide": 0.04,
      "carbondioxide": 0.27
    },
    "Outputs": {
      "glucose": 0.12
    },

Edit: I thought I did the "request changes with actual code" thing, but that clearly didn't work so I put it in this comment.

afbeelding

@domin2ktr
Copy link
Contributor Author

I think this balance already feels overall better for larger species.

At first I thought the increased efficiency for the chemoplast was a bit too much, but it's actually pretty consistent with the other eukaryote organelles. I actually think it could be tuned up a bit more. (And the CO2 input updated to match the glucose output).

I would do:

    "Inputs": {
      "hydrogensulfide": 0.04,
      "carbondioxide": 0.27
    },
    "Outputs": {
      "glucose": 0.12
    },

Edit: I thought I did the "request changes with actual code" thing, but that clearly didn't work so I put it in this comment.

afbeelding

I changed it to what you requested.

@Accidental-Explorer
Copy link
Contributor

I changed it to what you requested.

Mostly, but I would still like to increase the CO2 input of the eukaryotic chemosynthesis to 0.27 like in that comment, to make the conversion rate of CO2 into glucose consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

4 participants