Conversation
|
The lead programmer for Thrive is currently on vacation until 2026-01-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged. |
|
Haven't had a chance to test yet, but: I see you made prokaryotic chemosynthesis twice as efficient, but eukaryotic chemosynthesis almost 4 times more efficient. Is that much of a difference really necessary? (I do see that pre-this PR, the eukaryotic version is less efficient, so the current state in master is definitely also not good) |
There was a problem hiding this comment.
I think this balance already feels overall better for larger species.
At first I thought the increased efficiency for the chemoplast was a bit too much, but it's actually pretty consistent with the other eukaryote organelles. I actually think it could be tuned up a bit more. (And the CO2 input updated to match the glucose output).
I would do:
"Inputs": {
"hydrogensulfide": 0.04,
"carbondioxide": 0.27
},
"Outputs": {
"glucose": 0.12
},
Edit: I thought I did the "request changes with actual code" thing, but that clearly didn't work so I put it in this comment.
Mostly, but I would still like to increase the CO2 input of the eukaryotic chemosynthesis to 0.27 like in that comment, to make the conversion rate of CO2 into glucose consistent. |

Brief Description of What This PR Does
This PR increases the efficiency of chemosynthesis severalfold.
Why?
The fact is that chemosynthesis is terribly inefficient; it's barely enough for large prokaryotes to survive. And chemosynthetic eukaryotes starve even standing in a cloud of hydrogen sulfide.
In real life, chemosynthesis is efficient enough to fuel even some macroscopic organisms.
Furthermore, it requires organelles to convert glucose into ATP, which requires more organelles and, consequently, osmoregulation.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.