FIXING ISSUE #6728 : Game crashing on physics debug draw when AVX is disabled.#6732
Open
RyuDanuer wants to merge 2 commits intoRevolutionary-Games:masterfrom
Open
FIXING ISSUE #6728 : Game crashing on physics debug draw when AVX is disabled.#6732RyuDanuer wants to merge 2 commits intoRevolutionary-Games:masterfrom
RyuDanuer wants to merge 2 commits intoRevolutionary-Games:masterfrom
Conversation
…lutionary-Games#6728 Implemented a targeted fix for Revolutionary-Games#6728 by removing persisted RVec3Arg usage from the physics debug draw data path. The debug-draw pipeline no longer stores/passes RVec3Arg references across frames/callbacks; it now uses owned JPH::RVec3 values. Non-AVX compile validation succeeded for the extension path (THRIVE_AVX=OFF), producing libthrive_extension_without_avx.dll, so the cross-module signature changes are consistent.
FIXING Game crashing on physics debug draw when AVX is disabled. Revolutionary-Games#6728
Member
|
This PR has the same git issue as your other one with just the full files marked as new so I can't really see what the actual changes are here yet. So that git problem needs fixing first. One thing I'd like to note is that you can use force pushing to replace any commits in this PR so you don't have to close and open a bunch of new ones testing what works. |
Author
|
im new to github. i will check how to do that! but in the past few days i started working on this project, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Description of What This PR Does
Implemented a targeted fix for #6728 by removing persisted RVec3Arg usage from the physics debug draw data path.
The debug-draw pipeline no longer stores/passes RVec3Arg references across frames/callbacks; it now uses owned JPH::RVec3 values.
Non-AVX compile validation succeeded for the extension path (THRIVE_AVX=OFF), producing libthrive_extension_without_avx.dll, so the cross-module signature changes are consistent.
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.