Skip to content

Stop ripples from being activated by currents#6795

Draft
dligr wants to merge 5 commits intomasterfrom
ripples_affected_by_currents
Draft

Stop ripples from being activated by currents#6795
dligr wants to merge 5 commits intomasterfrom
ripples_affected_by_currents

Conversation

@dligr
Copy link
Member

@dligr dligr commented Mar 11, 2026

Brief Description of What This PR Does

Make the ripple display take currents into account, making it so that moving along currents doesn't turn them on.

This approach uses the dot product of the currents movement and the microbe movement. I have also tested a different approach which made currents only turn on if the player moves their cell, but that made the ripples turn off immediately after the player stopped moving.

Related Issues

Fixes #6726

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Fix the movement ripple effect triggering when carried by ocean currents

2 participants