Skip to content

feat: emit lockup_violation event on transfer revert (Closes #587) #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thlpkee20-wq merged 3 commits into from
Jul 29, 2026
Merged

feat: emit lockup_violation event on transfer revert (Closes #587) #692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6eb874
feat: emit lockup_violation event on transfer revert
emmyafolly123-coder Jul 29, 2026
47a5cd6
fix: use schedule enum in lockup violation event instead of unlock_ts
omolobamoyinoluwa-max Jul 29, 2026
9e42cda
Merge remote-tracking branch 'origin/master' into pr-692
thlpkee20-wq Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ pub enum RevoraError {
SignerKeyNotRegistered = 29,
/// The provided attestation network identifier does not match the active ledger network.
NetworkIdMismatch = 62,
/// Transfer blocked because shares are still locked (lockup schedule active).
LockupViolation = 63,
/// Multisig proposal has expired.
/// Wire value: 30. Stable since v1.
ProposalExpired = 30,
Expand Down Expand Up @@ -595,6 +597,9 @@ const EVENT_ADMIN_ROTATION_LOGGED: Symbol = symbol_short!("adm_log");
const EVENT_ADMIN_ROTATION_REVOKED: Symbol = symbol_short!("adm_rvk");
/// Emitted when a lockup schedule is configured for an offering.
const EVENT_LOCKUP_SET: Symbol = symbol_short!("lock_set");
/// Emitted when a transfer is attempted while the offering has active lockup restrictions.
/// Includes the caller, unlock timestamp, and attempted amount for indexer alerting.
const EVENT_LOCKUP_VIOLATION: Symbol = symbol_short!("lock_viol");
const EVENT_PLATFORM_FEE_SET: Symbol = symbol_short!("fee_set");
const EVENT_FRZ_SET: Symbol = symbol_short!("frz_set");
const EVENT_FRZ_CLR: Symbol = symbol_short!("frz_clr");
Expand Down Expand Up @@ -6802,6 +6807,19 @@ impl RevoraRevenueShare {
return Ok(());
}

// Lockup violation check: reject transfer if lockup is still active
if let Some(schedule) = Self::get_lockup_schedule(env.clone(), issuer.clone(), namespace.clone(), token.clone()) {
let now = env.ledger().timestamp();
let unlocked_bps = schedule.calculate_unlocked_bps(now);
if unlocked_bps < 10_000 {
env.events().publish(
(EVENT_LOCKUP_VIOLATION, from.clone()),
(to.clone(), amount_bps, schedule.clone()),
);
return Err(RevoraError::LockupViolation);
}
}

// Zero-value transfer is meaningless
if amount_bps == 0 {
return Err(RevoraError::InvalidAmount);
Expand Down
Loading