feat: add nonce and expiry to transfer attestations - #701
Merged
thlpkee20-wq merged 2 commits intoJul 29, 2026
Conversation
Add nonce and expiry to transfer_with_attestation to prevent attestation replay. - Extend transfer_with_attestation with attest_hash, network_id, nonce, and expires_at parameters - Add AttestationNonceUsed(Address, u64) variant to DataKey2 - Add network ID validation, nonce/expiry validation, and nonce consumption tracking (consumed only after all guards pass) - Add dual-party auth (from.require_auth, to.require_auth) - Add offering freeze, blacklist, whitelist, jurisdiction guards - Update atomic_swap to pass dummy attestation values (expires_at=0) - Add new tests for: expired attestation, nonce replay, per-signer nonce scoping, exact expiry boundary - Update event payload to include nonce and expires_at Closes RevoraOrg#561
|
@devv-leo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #561
Summary
Add nonce and expiry to transfer_with_attestation to prevent attestation replay. Nonces are per-signer (keyed by from address) and monotonically consumed.
Changes
Contract (src/lib.rs)
Tests
Security