Skip to content

Added Xerox write block function, plus remap for selection model/consumables - #3331

Draft
JeroenSteen wants to merge 10 commits into
RfidResearchGroup:masterfrom
JeroenSteen:master
Draft

Added Xerox write block function, plus remap for selection model/consumables#3331
JeroenSteen wants to merge 10 commits into
RfidResearchGroup:masterfrom
JeroenSteen:master

Conversation

@JeroenSteen

Copy link
Copy Markdown

Added the following:

  • Write-commando (0x31) found from sniff trace to protocols.h
  • Write block function, the tag response still needs to be handled
  • JSON-data for printermodels/consumables (some partnumbers are duplicated or imperfect) named xerox.json.
  • Remap function concept for selection model/consumables (gives error: Segmentation fault $CLIENT "$@").

@github-actions

Copy link
Copy Markdown

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001

Copy link
Copy Markdown
Collaborator

Cool PR,

Some quick feedback,

  • I notice more and more custom json handling everywhere in the client. We trying to funnel all file operations into fileutils.c
  • Custom spacing and long oneliners, they are not worth doing since we run make style onto the source code.

If you are using an AI , please tell it to read CONTRIBUTING.md and run make style before making a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants