Skip to content

fix: Make subprocess shell usage explicit in fm11rf08s_recovery.py #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orbisai0security wants to merge 2 commits into from
+4 −4
Closed

fix: Make subprocess shell usage explicit in fm11rf08s_recovery.py #3345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6cd4c2
fix: sanitize shell/subprocess call in fm11rf08s_recovery.py
orbisai0security Jun 2, 2026
b1dbc2b
chore: remove pytest regression test that doesn't fit project convent…
orbisai0security Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions client/pyscripts/fm11rf08s_recovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,12 @@ def show_key(sec, key_type, key):
nt[sec][key_type], nt_enc[sec][key_type], par_err[sec][key_type]]
if debug:
print(' '.join(cmd))
subprocess.run(cmd, capture_output=True)
subprocess.run(cmd, capture_output=True, shell=False)
cmd = [staticnested_2x1nt_path,
f"keys_{uid:08x}_{real_sec:02}_{nt[sec][0]}.dic", f"keys_{uid:08x}_{real_sec:02}_{nt[sec][1]}.dic"]
if debug:
print(' '.join(cmd))
subprocess.run(cmd, capture_output=True)
subprocess.run(cmd, capture_output=True, shell=False)
filtered_dicts[sec][key_type] = True
for key_type in [0, 1]:
keys_set = set()
Expand All @@ -300,7 +300,7 @@ def show_key(sec, key_type, key):
f"keys_{uid:08x}_{real_sec:02}_{nt[sec][key_type]}_filtered.dic"]
if debug:
print(' '.join(cmd))
result = subprocess.run(cmd, capture_output=True, text=True).stdout
result = subprocess.run(cmd, capture_output=True, text=True, shell=False).stdout
keys_def_set = set()
for line in result.split('\n'):
matched = match_key(line)
Expand Down Expand Up @@ -332,7 +332,7 @@ def show_key(sec, key_type, key):
nt[sec][key_type], nt_enc[sec][key_type], par_err[sec][key_type]]
if debug:
print(' '.join(cmd))
subprocess.run(cmd, capture_output=True)
subprocess.run(cmd, capture_output=True, shell=False)
keys_set = set()
with (open(f"keys_{uid:08x}_{real_sec:02}_{nt[sec][key_type]}.dic")) as f:
while line := f.readline().rstrip():
Expand Down
Loading