fix: FM11RF08S key recovery generates incorrect results when nt == 0 - #3436
Open
nffq wants to merge 1 commit into
Open
fix: FM11RF08S key recovery generates incorrect results when nt == 0#3436nffq wants to merge 1 commit into
nt == 0#3436nffq wants to merge 1 commit into
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
prev_lfsr16incmdhfmfsen.candstaticnested_2x1nt_rf08s*.cmaps nonce 0 to 0xFFFF when it should map to 0, generating incorrect results forcompute_seednt16_nt32and failing to recover the key.Fix: A new
init_lfsr16_tableimplementation that correctly maps 0 to itself.