Fix utime sometimes failing #1826
Open
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @JxxIT for bug, code |
|
Thanks for this! Unfortunately GitHub has done something to the macOS runners that is causing all tests to fail. I will hold on merging this until I can get tests figured out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that sometimes the date doesn't get changed.
For those interested, here's the investigation process:
I noticed that a process called
getattrlistread and wrote to the file. Within less than 1 ms, the date changed.getattrlistis an underlying component of Spotlight/MacOS that caches metadata. When theF_NOCACHEflag is added, MacOS no longer caches this information, resolving the issue.Fixes #1820