rebase #2

kittuov · 2020-12-09T04:52:42Z

No description provided.

Set the frameHeader when reading the file so the currentTimestamp actually gets set

Generated by renovateBot

Test that NACKs are negotiated correctly, and that we receive the expected NACK if we negotiated it.

This reverts commit 4f40756.

This reverts commit dbe26d3.

Fixes an issue where calling dataChannel.Close on 'connecting' state channels didn't work as expected. When handling the `OnOpen` event detect if the user has requested close. Fixes #2659

InboundRTPStreamStats: * https://www.w3.org/TR/webrtc-stats/#dom-rtcinboundrtpstreamstats-pausecount * https://www.w3.org/TR/webrtc-stats/#dom-rtcinboundrtpstreamstats-totalpausesduration * https://www.w3.org/TR/webrtc-stats/#dom-rtcinboundrtpstreamstats-freezecount * https://www.w3.org/TR/webrtc-stats/#dom-rtcinboundrtpstreamstats-totalfreezesduration * https://www.w3.org/TR/webrtc-stats/#dom-rtcinboundrtpstreamstats-powerefficientdecoder OutboundRTPStreamStats: * https://www.w3.org/TR/webrtc-stats/#dom-rtcoutboundrtpstreamstats-powerefficientencoder * https://www.w3.org/TR/webrtc-stats/#dom-rtcoutboundrtpstreamstats-scalabilitymode

One variable was misnamed, and we never checked for the end of the RTCP loop.

Mention that it must be called after registering codecs.

…Candidate (#2990) #### Description Currently, Pion returns an empty `sdpMid` and a 0 `sdpMLineIndex`. This PR ensures Pion returns the corresponding `sdpMid` and `sdpMLineIndex` for ICE candidates for clients that expects it. Fixes trickle issues. #### Changes 1. `ICECandidates`: New fields `SDPMid` and `SDPMLineIndex`. 2. `ICEGatherer`: `SetMediaStreamIdentification` and return the correct `SDPMid` and `SDPMLineIndex`. 3. `extractICEDetails`: Return a struct instead of multiple values. 4. `extractICEDetails` refactored the media description selection to a different function. 5. Added new tests. #### Reference issue Fixes #2690 Fixes #1833

#### Description [RFC 6386](https://www.rfc-editor.org/rfc/rfc6386#section-9.1) describes the least significant bit of the first byte of the header as: ``` A 1-bit frame type (0 for key frames, 1 for interframes). ``` The change is functionally a no-op, but the naming implies the wrong logic (you would assume `isKeyFrame == 1` means it is a key frame, but the opposite is true). #### Reference issue Fixes #...

Finish moving SDESRTPStreamIDURI from here to pion/sdp.

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/pion/ice/v4](https://redirect.github.com/pion/ice) | `v4.0.3` -> `v4.0.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fpion%2fice%2fv4/v4.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fpion%2fice%2fv4/v4.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fpion%2fice%2fv4/v4.0.3/v4.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fpion%2fice%2fv4/v4.0.3/v4.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pion/ice (github.com/pion/ice/v4)</summary> ### [`v4.0.4`](https://redirect.github.com/pion/ice/releases/tag/v4.0.4) [Compare Source](https://redirect.github.com/pion/ice/compare/v4.0.3...v4.0.4) #### What's Changed - docs(agent_config.go): update KeepaliveInterval default value to 2 sec by [@amincheloh](https://redirect.github.com/amincheloh) in [https://github.com/pion/ice/pull/730](https://redirect.github.com/pion/ice/pull/730) - Add nil checks to agent_handlers by [@dkess](https://redirect.github.com/dkess) in [https://github.com/pion/ice/pull/751](https://redirect.github.com/pion/ice/pull/751) - Use addrEqual for candidate comparison by [@paulwe](https://redirect.github.com/paulwe) in [https://github.com/pion/ice/pull/752](https://redirect.github.com/pion/ice/pull/752) #### New Contributors - [@amincheloh](https://redirect.github.com/amincheloh) made their first contribution in [https://github.com/pion/ice/pull/730](https://redirect.github.com/pion/ice/pull/730) **Full Changelog**: pion/ice@v4.0.3...v4.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Fulfill request changes in PR 3009 Close answer and assert errors in detach tests

Generated by renovateBot

Add H265 payloader support to mediaengine using Pion RTP v1.8.11.

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

The removed comment predates the introduction of locks in the RegisterCodec method.

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/pion/ice/v4](https://redirect.github.com/pion/ice) | `v4.0.5` -> `v4.0.6` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fpion%2fice%2fv4/v4.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fpion%2fice%2fv4/v4.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fpion%2fice%2fv4/v4.0.5/v4.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fpion%2fice%2fv4/v4.0.5/v4.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pion/ice (github.com/pion/ice/v4)</summary> ### [`v4.0.6`](https://redirect.github.com/pion/ice/releases/tag/v4.0.6) [Compare Source](https://redirect.github.com/pion/ice/compare/v4.0.5...v4.0.6) #### Changelog - [`d21ae5e`](https://redirect.github.com/pion/ice/commit/d21ae5e0e54465db200d27e6c61d2f44eb012aad) Include ufrag in generated ICE candidates - [`141df5a`](https://redirect.github.com/pion/ice/commit/141df5a086e3163106b3d721584ff8a7322b7b03) Update module github.com/pion/logging to v0.2.3 - [`9dfb5c2`](https://redirect.github.com/pion/ice/commit/9dfb5c26676a7f76fe9eafab5246cfb910d2d6e3) Allow for empty extension values - [`47dad55`](https://redirect.github.com/pion/ice/commit/47dad556f13a115afbc3120d565f6e4e09e3deec) Add methods to add and remove extensions - [`cad1676`](https://redirect.github.com/pion/ice/commit/cad1676659762c0c27d3495b061713c2d150a371) Upgrade golangci-lint, more linters </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/pion/stun/v3](https://redirect.github.com/pion/stun) | `v3.0.1` -> `v3.0.2` | ![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fpion%2fstun%2fv3/v3.0.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fpion%2fstun%2fv3/v3.0.1/v3.0.2?slim=true) | --- ### Release Notes <details> <summary>pion/stun (github.com/pion/stun/v3)</summary> ### [`v3.0.2`](https://redirect.github.com/pion/stun/releases/tag/v3.0.2) [Compare Source](https://redirect.github.com/pion/stun/compare/v3.0.1...v3.0.2) #### Changelog - [`9b2d7bc`](https://redirect.github.com/pion/stun/commit/9b2d7bcf7c9ca4aba87e692c45f8d26910da5d5a) Add AttrType.Known method - [`9bd9576`](https://redirect.github.com/pion/stun/commit/9bd95766b3c220464265e7396beca2d273dc7a4e) Update module github.com/pion/dtls/v3 to v3.0.8 ([#256](https://redirect.github.com/pion/stun/issues/256)) - [`ef6bc84`](https://redirect.github.com/pion/stun/commit/ef6bc8490ec0c1f28b6c8eecae5bb4637d5eaccc) Update module github.com/pion/transport/v3 to v3.1.1 - [`a8eac01`](https://redirect.github.com/pion/stun/commit/a8eac015c33d3d477c4ea9964d07c1f4327bb7b7) Update module github.com/pion/transport/v3 to v3.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Generated by renovateBot

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/pion/ice/v4](https://redirect.github.com/pion/ice) | `v4.0.13` -> `v4.1.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fpion%2fice%2fv4/v4.1.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fpion%2fice%2fv4/v4.0.13/v4.1.0?slim=true) | --- ### Release Notes <details> <summary>pion/ice (github.com/pion/ice/v4)</summary> ### [`v4.1.0`](https://redirect.github.com/pion/ice/releases/tag/v4.1.0) [Compare Source](https://redirect.github.com/pion/ice/compare/v4.0.13...v4.1.0) #### Changelog - [`a42e726`](https://redirect.github.com/pion/ice/commit/a42e726bb32f0e7e6ebef8200913ddab5eebd2b7) Deprecate AgentConfig - [`f808e10`](https://redirect.github.com/pion/ice/commit/f808e10d4542956a198cccc359ac397cb7261680) Allow any port range - [`58ab74b`](https://redirect.github.com/pion/ice/commit/58ab74b1679e20b21251668d99cc0066403e1a88) Update module github.com/pion/dtls/v3 to v3.0.9 - [`030bb33`](https://redirect.github.com/pion/ice/commit/030bb33178b483aaf383f5046877b5d3118d3539) Advertise only tcp-mux bind address - [`8d84083`](https://redirect.github.com/pion/ice/commit/8d84083ff4c1076835d16f95536586750a5cb3e2) Update golang Docker tag to v1.25 ([#847](https://redirect.github.com/pion/ice/issues/847)) - [`c29a72c`](https://redirect.github.com/pion/ice/commit/c29a72c5905ac4b6baf29c29c64367a7202769bc) Update module github.com/pion/stun/v3 to v3.0.2 ([#844](https://redirect.github.com/pion/ice/issues/844)) - [`fc739a1`](https://redirect.github.com/pion/ice/commit/fc739a1d5a3ff5b7a240ccee534bec3696d040a5) Emit a disconnected state before failing - [`ff7c443`](https://redirect.github.com/pion/ice/commit/ff7c443afe631001d89c6d73a207b105a1e79137) Return early if ctx is cancelled - [`7ce2014`](https://redirect.github.com/pion/ice/commit/7ce2014eaebd493cd4aeaea6596e8a19ac9966c2) Add AddressRewriter rules </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Do not wait on data channel Accept when SCTP association is aborted

Generated by renovateBot

Add a warning that it's a single track / header instead. And plan the deprecation for the next major release.

Update lint scripts and CI configs.

Generated by renovateBot

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/pion/rtp](https://redirect.github.com/pion/rtp) | `v1.8.27` -> `v1.9.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fpion%2frtp/v1.9.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fpion%2frtp/v1.8.27/v1.9.0?slim=true) | --- ### Release Notes <details> <summary>pion/rtp (github.com/pion/rtp)</summary> ### [`v1.9.0`](https://redirect.github.com/pion/rtp/releases/tag/v1.9.0) [Compare Source](https://redirect.github.com/pion/rtp/compare/v1.8.27...v1.9.0) #### Changelog - [`5cd305b`](https://redirect.github.com/pion/rtp/commit/5cd305b584c5f52542d9ceefb3754f0f0c09483c) Add H266 de/packetizer ([#347](https://redirect.github.com/pion/rtp/issues/347)) - [`1f90ade`](https://redirect.github.com/pion/rtp/commit/1f90ade2f0c0cedb25c344026fbb4924fa356ad8) Fix new lints - [`d408104`](https://redirect.github.com/pion/rtp/commit/d4081042f72a165949116cab2528cd008d2e164c) Update CI configs to v0.11.36 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

edaniels force-pushed the master branch from 7ee3b54 to 098d4ba Compare February 9, 2023 14:14

Sean-Der force-pushed the master branch from 93c1918 to e409a1d Compare September 17, 2023 04:12

Sean-Der force-pushed the master branch from 1bbaaea to b8fcf99 Compare April 3, 2024 16:52

aalekseevx and others added 27 commits December 26, 2024 23:34

Add Encoder/Decoder info to stats

80b5649

Fix bandwidth-estimation-from-disk timestamping

dca5d74

Set the frameHeader when reading the file so the currentTimestamp actually gets set

Update module golang.org/x/net to v0.33.0

384646e

Generated by renovateBot

Fix broken links in save-to-disk examples

92d573c

Add an end-to-end test for the NACK sender

92fce5f

Test that NACKs are negotiated correctly, and that we receive the expected NACK if we negotiated it.

Revert "IVF writer fix invalid timestamp into headers"

0ae39fd

This reverts commit 4f40756.

Revert "Adapt an existing test to provide coverage"

8b3734e

This reverts commit dbe26d3.

Fix IVF timestamps

31d8dbc

Nits

04b4621

Restore relative timestamp

d5e07a1

Defense against timebase with denominator 0

40358b3

Defense against timebase with denominator 0

1ee0299

Gracefully close connecting channels (#2991)

c895252

Fixes an issue where calling dataChannel.Close on 'connecting' state channels didn't work as expected. When handling the `OnOpen` event detect if the user has requested close. Fixes #2659

Minor fixes to TestInterceptorNack

6f6231b

One variable was misnamed, and we never checked for the end of the RTCP loop.

Improve documentation of ConfigureTWCCSender

c50ca41

Mention that it must be called after registering codecs.

Finish moving SDESRTPStreamIDURI (#3000)

f2191fb

Finish moving SDESRTPStreamIDURI from here to pion/sdp.

Fix deadlock in DataChannel with mutex unlock

fe41afd

Fulfill request changes in PR 3009 Close answer and assert errors in detach tests

Update module github.com/pion/ice/v4 to v4.0.5

608d35f

Generated by renovateBot

Add H265 payloader

99dcc6b

Add H265 payloader support to mediaengine using Pion RTP v1.8.11.

Upgrade golangci-lint, more linters

feeeebf

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Remove outdated safety comment in RegisterCodec

47c65c8

The removed comment predates the introduction of locks in the RegisterCodec method.

renovate bot and others added 30 commits December 6, 2025 04:54

Implement deadlines for mux

79d7571

Option to check for fingerprint in DTLS handshake

0936b7d

Implement GetRemoteCertificate for wasm

3a4d3be

Test wasm GetRemoteCertificate

8d685da

Permissively parse SDPs unless completely invalid

db10b6f

Update module github.com/pion/dtls/v3 to v3.0.9

0bb1745

Generated by renovateBot

Parse opus mappings

19e6521

Multi track ogg API

1584ffd

Parse ogg vorbis tags

604582a

Add playlist control example

156094c

Return early if aborted

1519afa

Do not wait on data channel Accept when SCTP association is aborted

Fix drift in WriteSample

ef58d38

Fix wrong stub comments

3ea3643

Implement write deadline

d475f2c

Use ICE options API

4f7fcbe

Wire and test renomination

2b85bef

Add Address-rewrite API

ab5a720

Add nohost gather policy

cf04e20

Add an option to include SEI NALs for H264/H265 (#3313)

7298add

Update module github.com/pion/rtp to v1.8.27

f2fe992

Generated by renovateBot

Update module github.com/pion/sdp/v3 to v3.0.17

0f4f3a0

Generated by renovateBot

Advertise ICE renomination option

d8828d6

Undo OGG API deprecation

39dee98

Add a warning that it's a single track / header instead. And plan the deprecation for the next major release.

Update CI configs to v0.11.36

b997b87

Update lint scripts and CI configs.

Update module github.com/pion/sctp to v1.9.0

45fa3ed

Generated by renovateBot

Check for closed receiver before setting up rid

48f7ac7

Assert no repair after stop

a5ce252

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rebase #2

rebase #2

Uh oh!

kittuov commented Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rebase #2

Are you sure you want to change the base?

rebase #2

Uh oh!

Conversation

kittuov commented Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants