rebase #2
Open
rebase #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly mentions v4 in Usage
Replaces fa1f5d9 which returned only a head packet's header. When the option WithRTPHeaders is set, SampleBuilder returns RTP headers of the packets forming the sample as Sample.RTPHeaders.
Use Sample.PacketTimestamp field instead. Migration example: - sample, timestamp := s.PopWithTimestamp() + sample := s.Pop() + timestamp := sample.PacketTimestamp BREAKING CHANGE: SampleBuilder.PopWithTimestamp method is removed
Deprecated by #1928 BREAKING CHANGE: samplebuilder.WithPartitionHeadChecker option is removed.
Generated by renovateBot
golangci-lint upgrade to v1.56.2 added more checks Relates to pion/.goassets#201
Removes repetitive words
Generated by renovateBot
In the case where a remote track is sending PCMU with payload type 0 checkAndUpdateTrack will fail to update the track codec and params (because t.PayloadType() is already 0). Add an extra check to handle this case.
Old versions of Pion break against it
Allows the user to cap the retranmission timeout, this change adds RTOMax to SettingEngine and pass it on when creating the SCTP Assocation
Skip registering the default codecs and interceptors in NewPeerConnection. The NewAPI() function already registers them by default (since #2630)
RTOMax wasn't actually being stored, is being pulled directly from SettingEngine
Create WHIP/WHEP example works with OBS or browser Resolves #2499
This allows users of detached datachannels to garbage collect resources associated with the datachannel and the sctp stream. There is no functional change here.
Generated by renovateBot
Update lint scripts and CI configs.
Generated by renovateBot
Chrome doesn't include the msid when responding to recvonly transceivers See crbug[0] for discussion [0] https://issues.chromium.org/u/1/issues/328522463
Update lint scripts and CI configs.
Relates to #2292
Generated by renovateBot
Expose ToICE() method on ICE candidates to allow for easier conversion to ice package ICE candidates. Resolve #3069
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/pion/ice/v4](https://redirect.github.com/pion/ice) | `v4.0.8` -> `v4.0.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pion/ice (github.com/pion/ice/v4)</summary> ### [`v4.0.9`](https://redirect.github.com/pion/ice/releases/tag/v4.0.9) [Compare Source](https://redirect.github.com/pion/ice/compare/v4.0.8...v4.0.9) #### What's Changed - Handle candidate: prefix with UnmarshalCandidate by [@​JoeTurki](https://redirect.github.com/JoeTurki) in [https://github.com/pion/ice/pull/769](https://redirect.github.com/pion/ice/pull/769) **Full Changelog**: pion/ice@v4.0.8...v4.0.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Use testify's assert package instead of the standard library's testing package.
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/pion/dtls/v3](https://redirect.github.com/pion/dtls) | `v3.0.4` -> `v3.0.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pion/dtls (github.com/pion/dtls/v3)</summary> ### [`v3.0.6`](https://redirect.github.com/pion/dtls/releases/tag/v3.0.6) [Compare Source](https://redirect.github.com/pion/dtls/compare/v3.0.5...v3.0.6) #### What's Changed - Revert rollback Go version bump by Renovate by [@​JoeTurki](https://redirect.github.com/JoeTurki) in [https://github.com/pion/dtls/pull/700](https://redirect.github.com/pion/dtls/pull/700) **Full Changelog**: pion/dtls@v3.0.5...v3.0.6 ### [`v3.0.5`](https://redirect.github.com/pion/dtls/releases/tag/v3.0.5) [Compare Source](https://redirect.github.com/pion/dtls/compare/v3.0.4...v3.0.5) #### Changelog - [`fbc7bae`](https://redirect.github.com/pion/dtls/commit/fbc7bae955bde9270dca5e0c5595896cfe9c4b2d) Update docker.io/library/golang Docker tag to v1.24 ([#​694](https://redirect.github.com/pion/dtls/issues/694)) - [`13b929b`](https://redirect.github.com/pion/dtls/commit/13b929b076c4503b206c9cfa7d118472b55006e6) Update module golang.org/x/net to v0.37.0 ([#​697](https://redirect.github.com/pion/dtls/issues/697)) - [`3a0f50a`](https://redirect.github.com/pion/dtls/commit/3a0f50af7df4355fd3107f874446e64309c9b019) Use crypto.Signer whenever possible ([#​681](https://redirect.github.com/pion/dtls/issues/681)) - [`16d6306`](https://redirect.github.com/pion/dtls/commit/16d630638a22ed42fa5881a88a00e6357c822f48) Update module golang.org/x/net to v0.34.0 ([#​693](https://redirect.github.com/pion/dtls/issues/693)) - [`8eb9a91`](https://redirect.github.com/pion/dtls/commit/8eb9a91be4fd045f3ac20728db4d353a494f2d3c) Upgrade golangci-lint, more linters - [`1c0df61`](https://redirect.github.com/pion/dtls/commit/1c0df61a228f240c27d3ef69b3eeea679de70d2c) Update module github.com/pion/logging to v0.2.3 ([#​691](https://redirect.github.com/pion/dtls/issues/691)) - [`1e4ae60`](https://redirect.github.com/pion/dtls/commit/1e4ae60e28516c475e999b389bcbe96a168c4470) Update module golang.org/x/net to v0.33.0 \[SECURITY] - [`ceb8458`](https://redirect.github.com/pion/dtls/commit/ceb84588accbb1b0ca0a51e807cc0062278c6d38) Update module golang.org/x/crypto to v0.31.0 \[SECURITY] - [`4e34db5`](https://redirect.github.com/pion/dtls/commit/4e34db5ca6566b816295c74f5e547fc260a69749) Update module golang.org/x/net to v0.31.0 - [`02434c7`](https://redirect.github.com/pion/dtls/commit/02434c73b48f63397b58dc1f7615b62575f0e93e) Update module golang.org/x/crypto to v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/pion/webrtc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOTQuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#### Description Before this, any interceptor that tries to read FEC payload type from `info *interceptor.StreamInfo`, always gets 0. This PR implements the logic to find FEC payload type. Also, MimeType consts are moved from mediaengine.go to mimetype.go, since mediaengine.go is not included in the WASM build.
Wait for PeerConnection to reach 'connected' in NACK test. Otherwise test will fail.
Don't use same error in goroutine
If IPv6 is supported assert that Pion can connect via it. Resolves #1315
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
It simplifies tracking amount of unsent data for all data channels, including ones in closing state. Especially useful for IoT apps which use multiple data channels and have to monitor memory usage.
H265 will be available by default now
TestBadCertificate is no longer needed for 1.24+ ``` CreateCertificate will now generate a serial number using a RFC 5280 compliant method when passed a template with a nil Certificate.SerialNumber field, instead of failing. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.