Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pacu session has a gov region set, calls to partiaional services are sent to the wrong partition. (partitional services are typically sent to a different host, ie standard-partition
iam.amazonaws.comvs govcloud partitioniam.us-gov.amazonaws.com)awscli/Boto3 handle partition resolution based on region automatically; you just need to pass the region.
When pacu instantiates a boto3 client the region param has a default of "None", and so when the client calls partitional services, it is unaware of the set region and fails to resolve to the correct partition. The API call gets sent to the wrong host. In this case that means GovCloud keys are being sent to the standard AWS partition for partitional services like IAM; since the keys are for govcloud they don't work in the standard partition.
This PR dynamically sets the default region on boto3 client instantiation; the region is pulled from the current pacu session's set regions
PacuSession.session_regions[0]This just changes the default, should be unlikely to break anything. Any modules or code paths that are specifying a region should not be affected by this change.