fix: resolve --version returning unknown in Docker#505
Open
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Open
fix: resolve --version returning unknown in Docker#505raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
get_pacu_version()readspyproject.tomlby walking up frompacu/main.py.After
pip install .(as the Dockerfile does), the code runs from site-packageswhere
pyproject.tomldoesn't exist, so it falls back to "unknown".Fix: use
importlib.metadata.version()(stdlib since Python 3.8) as the primarysource. This reads from installed package metadata, which
pip installpopulatescorrectly. The
pyproject.tomlfallback stays for development installs.