fix: false positive success message in iam__privesc_scan#506
Open
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Open
fix: false positive success message in iam__privesc_scan#506raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #483
iam__privesc_scanreports "Privilege escalation was successful" evenwhen every method fails. The check
if response is Falseuses identitycomparison, so if an escalation method returns
None(e.g. falling througha try/except without an explicit return),
None is Falseevaluates toFalseand the code treats it as a success.Fix: change
if response is Falsetoif not responseso thatNone,False, and any other falsy return value is correctly treated as failure.