Add shopspring/decimal support to avoid float precisions #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Rhymond, can you please have a look once you are free? I think it might be beneficial for some users |
|
hi @ocakhasan to: @Rhymond |
|
Any news on this? Would really like to see this one merged because we're having trouble with floats as-well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First of all thanks for creating such a package, it can be really handy for some cases. I saw that for some of the issues below
#124
#121
The output is wrong which may cause huge problems since this package is used for money operations. I wanted to add https://github.com/shopspring/decimal support to avoid float precisions.