fix: include user-defined LLM families in _resolve_architectures - #2
Closed
Ricardo-M-L wants to merge 1 commit into
Closed
fix: include user-defined LLM families in _resolve_architectures#2Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
The _resolve_architectures method only looked up architectures from BUILTIN_LLM_FAMILIES, which caused custom-registered models with a model_family pointing to a user-defined model to fail architecture resolution. Now combines both builtin and user-defined families. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
Closing — staging PR on my own fork; upstream is xorbitsai#4860. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolve_architecturesinllm_family.pyto include user-defined LLM families when resolving model architecturesmodel_familypointing to a user-defined model would fail architecture resolutionProblem
When a user registers a custom LLM model and specifies
model_familythat references another user-defined model (not a builtin), the_resolve_architecturesmethod would returnNonebecause it only looked up inBUILTIN_LLM_FAMILIES.Solution
Build a combined dictionary of both builtin and user-defined families, then look up the model_family from that combined dictionary.
Test plan
Generated with Claude Code