Clean up the list of clients by removing dead/invalid connections. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickySu
reviewed
Dec 5, 2016
| $this->clients = array_values(array_filter($this->clients, function($client) { | ||
| return !empty($client->app) && !empty($client->conn); | ||
| })); | ||
|
|
||
| $index = array_search($client, $this->clients, true); | ||
| if($index == false){ |
There was a problem hiding this comment.
If $client is the first element of $this->clients (means $this->clients[0]), the result of $index is 0.
Using strong type compare ($index === false) is better.
There was a problem hiding this comment.
You are right, that seems to be the cause all along. I've seen you have updated the master branch with this change, and everything seems to just run smoothly. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we get rid of invalid connections, so that we are able to avoid errors while trying to push updated data.